Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Release v1.6.0 #9807
🌱 Release v1.6.0 #9807
Changes from all commits
29dce57
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Q: Could it be that we only have one changelog entry for dependencies that have been bumped multiple times?
E.g. ginkgo in release-1.5 was not v2.13.0 as it seems here in the changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, we do remove "duplicated" entries for the same module
It's documented in the release process
We can discuss a process change, I don't mind having multiple entries for the same dependency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely let's not delay this release for it.
The main thing I don't like is that it now looks like we upgraded only from 2.13.0 to 2.13.1 (even though the source versions are totally different).
In the past I merged entries by modifying the source / target version to capture all bumps + add all the PRs.
As nobody actually cares about the bump PRs I think the ideal solution would be to be able to just generate the list of bumped dependencies and drop the individual PRs entirely from the release notes. This would give us also a more accurate and complete list of bumps (compare with what k/k is doing).
In any case, let's definitely keep it as is for now, but it might be worth a follow-up issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side note: I wonder if need a separate category for release, testing, etc. since there are so many "other" changes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also dependency