-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Release v1.6.0-beta.0 #9612
🌱 Release v1.6.0-beta.0 #9612
Conversation
0bca58d
to
3a5c1dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@g-gaston thank you, looks awesome!
Few nits + any diff of commits the PR is missing:
/hold To ensure this gets squashed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good - just some nits
5c4363e
to
d634c6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good - will take a final look once the commits are squashed.
/lgtm |
LGTM label has been added. Git tree hash: 07850d55be0881f8b6a01ea9f08d191f61d196fd
|
d634c6a
to
ffedbc1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One last nit
ffedbc1
to
b0e4577
Compare
b0e4577
to
750ca41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
/approve
/lgtm
Feel free to unhold
LGTM label has been added. Git tree hash: ae57afea6ed503fe0bf60bfd0127f64144635577
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @g-gaston!
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: furkatgofurov7, killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
/area release