Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Release v1.6.0-beta.0 #9612

Merged

Conversation

g-gaston
Copy link
Contributor

/area release

@k8s-ci-robot k8s-ci-robot added area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 23, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 23, 2023
@g-gaston g-gaston changed the title 🚀 Add release v1.6.0-beta.0 🚀 Release v1.6.0-beta.0 Oct 23, 2023
@g-gaston g-gaston force-pushed the notes-release-1.6.0-beta.0 branch from 0bca58d to 3a5c1dd Compare October 23, 2023 21:53
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@g-gaston thank you, looks awesome!

Few nits + any diff of commits the PR is missing:

CHANGELOG/v1.6.0-beta.0.md Outdated Show resolved Hide resolved
CHANGELOG/v1.6.0-beta.0.md Outdated Show resolved Hide resolved
CHANGELOG/v1.6.0-beta.0.md Outdated Show resolved Hide resolved
CHANGELOG/v1.6.0-beta.0.md Outdated Show resolved Hide resolved
@g-gaston g-gaston changed the title 🚀 Release v1.6.0-beta.0 🌱 Release v1.6.0-beta.0 Oct 24, 2023
@killianmuldoon
Copy link
Contributor

/hold

To ensure this gets squashed

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - just some nits

CHANGELOG/v1.6.0-beta.0.md Outdated Show resolved Hide resolved
CHANGELOG/v1.6.0-beta.0.md Outdated Show resolved Hide resolved
CHANGELOG/v1.6.0-beta.0.md Outdated Show resolved Hide resolved
CHANGELOG/v1.6.0-beta.0.md Outdated Show resolved Hide resolved
CHANGELOG/v1.6.0-beta.0.md Outdated Show resolved Hide resolved
CHANGELOG/v1.6.0-beta.0.md Outdated Show resolved Hide resolved
CHANGELOG/v1.6.0-beta.0.md Outdated Show resolved Hide resolved
CHANGELOG/v1.6.0-beta.0.md Outdated Show resolved Hide resolved
@g-gaston g-gaston force-pushed the notes-release-1.6.0-beta.0 branch from 5c4363e to d634c6a Compare October 24, 2023 16:15
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good - will take a final look once the commits are squashed.

@nawazkh
Copy link
Member

nawazkh commented Oct 24, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 07850d55be0881f8b6a01ea9f08d191f61d196fd

@g-gaston g-gaston force-pushed the notes-release-1.6.0-beta.0 branch from d634c6a to ffedbc1 Compare October 24, 2023 16:26
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023
@k8s-ci-robot k8s-ci-robot requested a review from nawazkh October 24, 2023 16:26
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last nit

CHANGELOG/v1.6.0-beta.0.md Outdated Show resolved Hide resolved
@g-gaston g-gaston force-pushed the notes-release-1.6.0-beta.0 branch from ffedbc1 to b0e4577 Compare October 24, 2023 16:33
@g-gaston g-gaston force-pushed the notes-release-1.6.0-beta.0 branch from b0e4577 to 750ca41 Compare October 24, 2023 16:34
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

/approve
/lgtm

Feel free to unhold

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ae57afea6ed503fe0bf60bfd0127f64144635577

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2023
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @g-gaston!

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: furkatgofurov7, killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@g-gaston
Copy link
Contributor Author

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit dd553a2 into kubernetes-sigs:main Oct 24, 2023
13 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release Issues or PRs related to releasing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants