Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump some dependencies in Makefile #9549

Merged
merged 1 commit into from
Oct 16, 2023
Merged

🌱 Bump some dependencies in Makefile #9549

merged 1 commit into from
Oct 16, 2023

Conversation

furkatgofurov7
Copy link
Member

What this PR does / why we need it:

This PR bumps:

  • HADOLINT_VER to v2.12.0
  • YQ_VER to v4.35.2
  • GOVULNCHECK_VER to v1.0.1
  • SETUP_ENVTEST_VER to latest
  • GOTESTSUM_VER to v1.11.0

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #9094

/area dependencies

@furkatgofurov7
Bump dependencies in Makefile
dc1573a 
This commit bumps tools used in Makefile to latest versions

Signed-off-by: Furkat Gofurov <[email protected]>
@k8s-ci-robot
Copy link
Contributor

@furkatgofurov7: The label(s) area/dependencies cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:

This PR bumps:

  • HADOLINT_VER to v2.12.0
  • YQ_VER to v4.35.2
  • GOVULNCHECK_VER to v1.0.1
  • SETUP_ENVTEST_VER to latest
  • GOTESTSUM_VER to v1.11.0

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #9094

/area dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot requested a review from enxebre October 13, 2023 09:25
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 13, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 13, 2023
@furkatgofurov7
Copy link
Member Author

/area dependency

@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes and removed do-not-merge/needs-area PR is missing an area label labels Oct 13, 2023
@furkatgofurov7
Copy link
Member Author

Looks like, we need to add /area dependency to the suggested list of labels that can be applied to PR/issues by bot

killianmuldoon
killianmuldoon reviewed Oct 13, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks for keeping on top of these.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2023
vincepri
vincepri approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9214c3b3d83ef82603284c8fc25dc52f55068cdd

@k8s-ci-robot k8s-ci-robot merged commit b1b6896 into kubernetes-sigs:main Oct 16, 2023
15 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Oct 16, 2023
@furkatgofurov7 furkatgofurov7 mentioned this pull request Oct 17, 2023
Closed
@furkatgofurov7
Copy link
Member Author

Looks like, we need to add /area dependency to the suggested list of labels that can be applied to PR/issues by bot

@killianmuldoon @vincepri here is the PR: kubernetes/test-infra#31048 to add the label in the list, PTAL

@furkatgofurov7 furkatgofurov7 deleted the bump-deps-capi branch October 17, 2023 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@vincepri vincepri vincepri approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@vincepri vincepri

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
4 participants
@furkatgofurov7 @k8s-ci-robot @vincepri @killianmuldoon