-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ promote IPAM types to v1beta1 #9525
Conversation
Hi @rvanderp3. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/area ipam |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking this on!
/ok-to-test
/hold placing hold while test failures are reviewed |
@rvanderp3 We should add the conversion webhooks as part of this PR, feel free to reach out if you have questions |
Sure thing, thanks! |
9396eee
to
b3b062a
Compare
07bfbff
to
51dba3d
Compare
/test pull-cluster-api-test-main |
/hold cancel |
/hold Just want to make sure this gets review from the right folks before its merged. |
/assign @schrej @tylerschultz @vincepri |
@rvanderp3: GitHub didn't allow me to assign the following users: tylerschultz. Note that only kubernetes-sigs members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
exp/ipam/api/v1alpha1/conversion.go
Outdated
return err | ||
} | ||
|
||
return utilconversion.MarshalData(src, dst) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to call MarshalData here if we aren't using it when converting back?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, we do not. i just removed it.
/test pull-cluster-api-test-main there seems to be a flake, i'll investigate and open an issue on this |
/lgtm |
LGTM label has been added. Git tree hash: 95eb99b6d225168bbc9dc38568d8e5471ff0d677
|
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Promotes IPAM types to v1beta1.
Which issue(s) this PR fixes:
Fixes #8694