Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.4] 🌱 Bump to Go 1.20.8 #9432

Merged
merged 1 commit into from
Sep 20, 2023
Merged

[release-1.4] 🌱 Bump to Go 1.20.8 #9432

merged 1 commit into from
Sep 20, 2023

Conversation

cahillsf
Copy link
Member

@cahillsf cahillsf commented Sep 14, 2023 •
edited
Loading

What this PR does / why we need it:
Bumps release-1.4 to address new CVE causing our GH action Weekly Security Scan to fail (example)

Pending merge of #9415

/area dependency

@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Sep 14, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 14, 2023
@cahillsf
Copy link
Member Author

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/needs-area PR is missing an area label label Sep 14, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2023
@cahillsf
Copy link
Member Author

/area dependency
/test all

@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes and removed do-not-merge/needs-area PR is missing an area label labels Sep 14, 2023
@sbueringer
Copy link
Member

/test ?

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-release-1-4
  • /test pull-cluster-api-e2e-full-release-1-4
  • /test pull-cluster-api-e2e-release-1-4
  • /test pull-cluster-api-e2e-workload-upgrade-1-26-1-27-release-1-4
  • /test pull-cluster-api-test-mink8s-release-1-4
  • /test pull-cluster-api-test-release-1-4
  • /test pull-cluster-api-verify-release-1-4

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-release-1-4
  • /test pull-cluster-api-e2e-informing-ipv6-release-1-4
  • /test pull-cluster-api-e2e-informing-release-1-4

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-release-1-4
  • pull-cluster-api-build-release-1-4
  • pull-cluster-api-e2e-informing-ipv6-release-1-4
  • pull-cluster-api-e2e-informing-release-1-4
  • pull-cluster-api-e2e-release-1-4
  • pull-cluster-api-test-mink8s-release-1-4
  • pull-cluster-api-test-release-1-4
  • pull-cluster-api-verify-release-1-4

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cahillsf cahillsf marked this pull request as ready for review September 14, 2023 13:27
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 14, 2023
@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-full-release-1-4
/test pull-cluster-api-e2e-workload-upgrade-1-26-1-27-release-1-4

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 14, 2023
killianmuldoon
killianmuldoon reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Do you mind squashing the commits and then we can run the tests again?

@sbueringer sbueringer changed the title [release-1.4] 🌱 bump release 1.4 to go 1.20.8 [release-1.4] 🌱 Bump to Go 1.20.8 Sep 14, 2023
@sbueringer
Copy link
Member

/lgtm

Thank you!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: bc24c5da75734afd55e156f787fc48e725977055

furkatgofurov7
furkatgofurov7 reviewed Sep 14, 2023
View reviewed changes
Copy link
Member

@furkatgofurov7 furkatgofurov7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

/lgtm

@cahillsf
bump release 1.4 to go 1.20.8
6b7d2b2 
bump min go to 1.20

add no-lint for SA1019 (rand.Seed deprecation in go 1.20)
@cahillsf
Copy link
Member Author

/test pull-cluster-api-e2e-full-release-1-4
/test pull-cluster-api-e2e-workload-upgrade-1-26-1-27-release-1-4

@sbueringer
Copy link
Member

/lgtm
/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 20, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7d78649 into kubernetes-sigs:release-1.4 Sep 20, 2023
10 checks passed
@cahillsf cahillsf deleted the bump-go-release-1.4 branch September 24, 2023 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@sbueringer sbueringer Awaiting requested review from sbueringer

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@sbueringer sbueringer

@furkatgofurov7 furkatgofurov7

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@cahillsf @k8s-ci-robot @sbueringer @furkatgofurov7 @killianmuldoon