Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.5] ✨ ClusterClass: Introduce NamingStrategy and allow generating names using go templates #9428

Merged
merged 1 commit into from
Sep 14, 2023
Merged

[release-1.5] ✨ ClusterClass: Introduce NamingStrategy and allow generating names using go templates #9428

merged 1 commit into from
Sep 14, 2023

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

This is a manual cherry-pick of:

The changes are only part of the experimental topology feature.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area topology

@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Sep 14, 2023
@k8s-ci-robot
Copy link
Contributor

@chrischdi: The label(s) area/topology cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:

This is a manual cherry-pick of:

The changes are only part of the experimental topology feature.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area topology

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi
Copy link
Member Author

/test help

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Sep 14, 2023
@k8s-ci-robot
Copy link
Contributor

@chrischdi: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-release-1-5
  • /test pull-cluster-api-e2e-release-1-5
  • /test pull-cluster-api-test-release-1-5
  • /test pull-cluster-api-verify-release-1-5

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-release-1-5
  • /test pull-cluster-api-e2e-full-dualstack-and-ipv6-release-1-5
  • /test pull-cluster-api-e2e-full-release-1-5
  • /test pull-cluster-api-e2e-informing-release-1-5
  • /test pull-cluster-api-e2e-mink8s-release-1-5
  • /test pull-cluster-api-e2e-scale-release-1-5-experimental
  • /test pull-cluster-api-e2e-workload-upgrade-1-27-1-28-release-1-5
  • /test pull-cluster-api-test-mink8s-release-1-5

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-release-1-5
  • pull-cluster-api-build-release-1-5
  • pull-cluster-api-e2e-informing-release-1-5
  • pull-cluster-api-e2e-release-1-5
  • pull-cluster-api-test-release-1-5
  • pull-cluster-api-verify-release-1-5

In response to this:

/test help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Sep 14, 2023
@chrischdi
Copy link
Member Author

/area clusterclass

/test pull-cluster-api-e2e-full-release-1-5

@k8s-ci-robot k8s-ci-robot added area/clusterclass Issues or PRs related to clusterclass and removed do-not-merge/needs-area PR is missing an area label labels Sep 14, 2023
@chrischdi chrischdi force-pushed the pr-topology-namestrategy-1-5 branch from 15f9f3a to d3c68bf Compare September 14, 2023 09:46
@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-full-release-1-5

killianmuldoon
killianmuldoon reviewed Sep 14, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

/hold

For CI

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 80a931c444112c684c974ce1e97d4c66f5b0d1bb

@sbueringer
Copy link
Member

I'll do a quick review after lunch

@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2023
@sbueringer
Copy link
Member

/hold cancel

🎉

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5d27ce3 into kubernetes-sigs:release-1.5 Sep 14, 2023
10 checks passed
@chrischdi chrischdi deleted the pr-topology-namestrategy-1-5 branch September 14, 2023 11:29
@chrischdi chrischdi mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@stmcginnis stmcginnis Awaiting requested review from stmcginnis

Assignees

@sbueringer sbueringer

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
4 participants
@chrischdi @k8s-ci-robot @sbueringer @killianmuldoon