-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Bump sigs.k8s.io/controller-runtime from 0.16.1 to 0.16.2 in /test #9406
🌱 Bump sigs.k8s.io/controller-runtime from 0.16.1 to 0.16.2 in /test #9406
Conversation
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/hold Let's wait for the top-level bump next week (v0.16.2 got released yesterday evening) |
Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.16.1 to 0.16.2. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/main/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.16.1...v0.16.2) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
da01d2d
to
86f0cfb
Compare
Ups accidentally merged the PR for hacks 😀 |
I think it should be fine to merge these for patch releases even if it's not in the correct order, no? Otherwise it might be better to revert the change to allow these dependabot PRs instead of having to remember to merge them in order. |
Yeah doesn't really matter. It's just test & hack (+ it works anyway, that's what we have CI for) Usually we just get one PR I guess but the CR release was after the Monday bump /hold cancel |
/lgtm |
LGTM label has been added. Git tree hash: bfaa7702e19f27080088b9218829b0961d32af77
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Bumps sigs.k8s.io/controller-runtime from 0.16.1 to 0.16.2.
Release notes
Sourced from sigs.k8s.io/controller-runtime's releases.
Commits
7db81c7
Merge pull request #2492 from k8s-infra-cherrypick-robot/cherry-pick-2472-to-...ca2d236
bug: Return NoResourceMatchError when appropriate for backwards compatibility.b40bcb8
[release-0.16] 🐛 Fix returning object after status update (#2490)1cf5b88
Merge pull request #2485 from k8s-infra-cherrypick-robot/cherry-pick-2484-to-...319038d
bug: Fix status subresource getting updated on Update when it is empty580f203
Merge pull request #2483 from k8s-infra-cherrypick-robot/cherry-pick-2479-to-...339df9a
delete copyNonStatusFrom function, change test case descriptionb3c83a2
add test case to show it will not override other status fields when updating74eb8ea
Test showing labels and annotations stored during fake client.Status().Update()f4582ea
update subresource client to not incude metadataDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major version
will close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor version
will close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>
will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>
will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>
will remove the ignore condition of the specified dependency and ignore conditions