-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Remove Kubeadm upstream v1beta1 types #9345
🌱 Remove Kubeadm upstream v1beta1 types #9345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/area provider/bootstrap-kubeadm
This PR contains #8997 I'll come back to it once that PR has been merged. |
e02eeb0
to
82cdae3
Compare
-2,5k loc would be nice |
82cdae3
to
ddbd9f0
Compare
Signed-off-by: killianmuldoon <[email protected]>
ddbd9f0
to
6a9aa07
Compare
@killianmuldoon: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
With this change CAPBK will fail hard if a Cluster of v1.15.0 or older is used - I wonder if we should reject this at the webhook level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: b57ef52bbf7465281fe7104391d0740919da10e4
|
I think this is something for the related issue around version validation across CAPI that is open since forever. |
nit: v1.15 itself would work |
Agreed - I hope nobody's trying to use current CAPI with v1.14.0 and it would probably fail pretty hard in other cases anyway. Cross-linking the other issue: #7010 |
Yup. We already have the same problem with 1.12 today 😂 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: killianmuldoon [email protected]
Remove Kubeadm v1beta1 types from the CAPI codebase.
According to the [Kubeadm docs] "kubeadm v1.22.x and newer no longer support v1beta1 and older APIs, but can be used to migrate v1beta2 to v1beta3". CAPI no longer supportes v1.22 management clusters, and will not support v1.22 workload clusters with the release of CAPI v1.6.0.
Part of #8038