🌱 Improve ClusterClass watch for ExtensionConfigs

[killianmuldoon]

Ensure the ClusterClass controller's watch on ExtensionConfigs correctly filters extensions so that only ClusterClasses referencing the config cause reconcile loops.

Fixes #8495

[killianmuldoon]

/area runtime-sdk

[sbueringer]

Would like to cherry-pick to release-1.5 based on

• Enhancements or additions to experimental Cluster API features, with the goal of allowing faster adoption and iteration;

/cherry-pick release-1.5

(technically this could also be seen as a bugfix as with a high number of ClusterClasses and ExtensionConfigs we trigger way too many reconciles today)

[k8s-infra-cherrypick-robot]

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you.

In response to this:

Would like to cherry-pick to release-1.5 based on>

• Enhancements or additions to experimental Cluster API features, with the goal of allowing faster adoption and iteration;

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

Thx!

Especially for the good test coverage!

/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: d59b055a826a5477cc33b59686d872056ff048bc

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

/hold

(just to actually run the affected e2e tests before we merge & cherry-pick)

[sbueringer]

/test pull-cluster-api-e2e-full-main

[k8s-ci-robot]

@killianmuldoon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-cluster-api-e2e-full-main	713fbfa	link	false	/test pull-cluster-api-e2e-full-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[killianmuldoon]

Failed the autoscaler test as expected - there's no rush to get this in until we have that fixed though.

[sbueringer]

Absolutely fine with me. I'm also fine with merging this as it's pretty clear that everything else is green and this PR can't break the autoscaler test further

[killianmuldoon]

Let's merge it then - one more piece of WIP off the table

/hold cancel

[k8s-infra-cherrypick-robot]

@sbueringer: new pull request created: #9356

In response to this:

Would like to cherry-pick to release-1.5 based on

• Enhancements or additions to experimental Cluster API features, with the goal of allowing faster adoption and iteration;

/cherry-pick release-1.5

(technically this could also be seen as a bugfix as with a high number of ClusterClasses and ExtensionConfigs we trigger way too many reconciles today)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.