🌱 Add test for ownerReference apiVersion update #9269
Conversation
Signed-off-by: killianmuldoon <[email protected]>
k8s-ci-robot
added
area/e2e-testing
k8s-ci-robot
added
the
size/L
| @@ -51,17 +49,6 @@ var _ = Describe("When testing clusterctl upgrades (v1.0=>current)", func() { | |||
| WorkloadKubernetesVersion: "v1.23.17", | |||
| MgmtFlavor: "topology", | |||
| WorkloadFlavor: "", | |||
| // This check ensures that ownerReference apiVersions are updated for all types after the upgrade. | |||
| PostUpgrade: func(proxy framework.ClusterProxy, namespace, clusterName string) { | |||
There was a problem hiding this comment.
I don't think these tests make sense any more as there's no longer any APIVersion upgrades in our clusterctl_upgrade tests.
This is something we should make sure is part of the introduction of v1beta1 or whatever the next APIVersion is.
There was a problem hiding this comment.
+1 except we already have v1beta1 :D
There was a problem hiding this comment.
Do you think we still need it now that we have ValidateOwnerReferencesOnUpdate in quickstart?
|
/retest |
|
Really nice one!! /approve /assign @fabriziopandini @chrischdi |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
Fine to cherry-pick from my side if we want to as it falls under |
|
/cherry-pick release-1.5 |
|
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.5 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 9ccc5b72c28a4e3a1e8ff2f9be1b109c60cf3fa9
|
|
/retest |
|
@killianmuldoon: new pull request created: #9295 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-1.5 |
|
@killianmuldoon: new pull request could not be created: failed to create pull request against kubernetes-sigs/cluster-api#release-1.5 from head k8s-infra-cherrypick-robot:cherry-pick-9269-to-release-1.5: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for k8s-infra-cherrypick-robot:cherry-pick-9269-to-release-1.5."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Strike that - the cherry-pick worked, but apparently too well 😆 |
Add an end-to-end test to ensure that the apiVersions of ownerReferences are updated to the current version of the CAPI APIs.
Fixes #7224
/area e2e-testing