Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 use goproxy to check version in clusterctl #9237

Merged
merged 1 commit into from
Aug 28, 2023
Merged

🌱 use goproxy to check version in clusterctl #9237

merged 1 commit into from
Aug 28, 2023

Conversation

fabriziopandini
Copy link
Member

What this PR does / why we need it:
Remove API calls to the rate-limited GitHub API

Which issue(s) this PR fixes:
Rif ##8426

/area clusterctl

@k8s-ci-robot k8s-ci-robot added the area/clusterctl Issues or PRs related to clusterctl label Aug 17, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 17, 2023
@fabriziopandini fabriziopandini mentioned this pull request Aug 17, 2023
Closed
Jont828
Jont828 reviewed Aug 17, 2023
View reviewed changes
Copy link
Contributor

@Jont828 Jont828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small thing, otherwise looks good!

cmd/clusterctl/cmd/version_checker.go Outdated Show resolved Hide resolved
cmd/clusterctl/cmd/version_checker.go Outdated Show resolved Hide resolved
chrischdi
chrischdi reviewed Aug 18, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general lgtm :-) open questions/nits

cmd/clusterctl/cmd/version_checker.go Outdated Show resolved Hide resolved
cmd/clusterctl/cmd/version_checker.go Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 18, 2023
@fabriziopandini fabriziopandini force-pushed the cluster-goproxy-version-check branch from 2b39230 to ac48f76 Compare August 18, 2023 18:37
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Aug 18, 2023
@fabriziopandini fabriziopandini force-pushed the cluster-goproxy-version-check branch from ac48f76 to 357078e Compare August 21, 2023 09:05
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 21, 2023
@sbueringer
Copy link
Member

@fabriziopandini Two nits otherwise ready from my side

@fabriziopandini fabriziopandini force-pushed the cluster-goproxy-version-check branch from 357078e to a731657 Compare August 25, 2023 19:13
@sbueringer sbueringer force-pushed the cluster-goproxy-version-check branch from a731657 to a2afb25 Compare August 28, 2023 13:06
@sbueringer
Copy link
Member

/approve

Pushed a minor fix (removed one more context.TODO), so leaving lgtm to someone else

/assign @killianmuldoon @chrischdi

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 28, 2023
chrischdi
chrischdi reviewed Aug 28, 2023
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 28, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 9235a5e1328b49739a6c371cae200d0499cf80d7

@k8s-ci-robot k8s-ci-robot merged commit 4867dad into kubernetes-sigs:main Aug 28, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 28, 2023
@fabriziopandini fabriziopandini deleted the cluster-goproxy-version-check branch November 17, 2023 10:38
@fabriziopandini fabriziopandini mentioned this pull request Jan 19, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@furkatgofurov7 furkatgofurov7 furkatgofurov7 left review comments

@Jont828 Jont828 Jont828 left review comments

@sbueringer sbueringer sbueringer left review comments

@chrischdi chrischdi chrischdi left review comments

@richardcase richardcase richardcase left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@chrischdi chrischdi

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.
8 participants
@fabriziopandini @sbueringer @k8s-ci-robot @richardcase @chrischdi @Jont828 @furkatgofurov7 @killianmuldoon