Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ClusterNetwork ClusterNetworkingConfig field optional within #919

Merged
merged 1 commit into from
Jun 20, 2019
Merged

Make ClusterNetwork ClusterNetworkingConfig field optional within #919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions pkg/apis/cluster/v1alpha1/cluster_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ type Cluster struct {
// ClusterSpec defines the desired state of Cluster
type ClusterSpec struct {
// Cluster network configuration
// +optional
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it becomes a question whether the API client spec is locked at this point for v1alpha1.
this falls under non-breaking changes, so it seems fine to modify the old config, but it's probably a good idea to clone v1alpha1 into v1alpha2 at this point, setup the roundtrip and start accepting changes there.

a google doc that collects ideas for v1alpha2 changes + a tracking issue that links to it would be nice too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setting up v1alpha2 is a bit more complicated than just roundtripping with apimachinery. It would require either:

  • a fully externalized upgrade path, where the v1alpha1 controllers are shut down, the CRDs are migrated to v1alpha2 and then the v1alpha2 controllers are brought up
  • a CRD conversion webhook that is built, deployed, and registered. This requires support from controller-runtime: CRD conversion webhooks support controller-runtime#275

ClusterNetwork ClusterNetworkingConfig `json:"clusterNetwork"`

// Provider-specific serialized configuration to use during
Expand Down