Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Bump golangci-lint to v1.54.1 #9174

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

killianmuldoon
Copy link
Contributor

Bump golangci-lint to v1.54.1.

The main feature here is go v1.21 support. Notes:

v1.54.0: https://github.com/golangci/golangci-lint/releases/tag/v1.54.0
v1.54.1: https://github.com/golangci/golangci-lint/releases/tag/v1.54.1

Signed-off-by: killianmuldoon <[email protected]>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 14, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 14, 2023
@sbueringer
Copy link
Member

/lgtm
/approve

@killianmuldoon
Copy link
Contributor Author

needs-area label working well 😃

/area ci

@k8s-ci-robot k8s-ci-robot added the area/ci Issues or PRs related to ci label Aug 14, 2023
@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/needs-area PR is missing an area label labels Aug 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0ee3a3c1e37df5c515751d996bc2e04210a85191

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 14, 2023
@sbueringer
Copy link
Member

needs-area label working well 😃

/area ci

The PR template not so much 😂

@k8s-ci-robot k8s-ci-robot merged commit 30e2caf into kubernetes-sigs:main Aug 14, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.6 milestone Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/ci Issues or PRs related to ci cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants