-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Add ClusterClass column to Cluster CRD #9120
Conversation
Signed-off-by: Stefan Büringer [email protected]
/area api (just barely) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
Feel free to unhold - just in case anyone else wants to take a look as it's an API change.
LGTM label has been added. Git tree hash: 250588dc8844c2aaacdef07428f470d01c01b95e
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Debatable if the columns of the CRD are an API :D But let's not go there. Thx for the review, I'll keep it open for a few days, I'm not in a rush |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold cancel |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Adds a ClusterClass column to the Cluster CRD. Super helpful to determine if a Cluster is a classy cluster, and if yes which ClusterClass it uses
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #