-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Change tilt debug base image to golang #9070
🐛 Change tilt debug base image to golang #9070
Conversation
Signed-off-by: killianmuldoon <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/area devtools
Probably should be cherry-picked at least to release-1.5 and release-1.4 |
For what it's worth. Random google results:
Let's definitely fix this on main for now. Would be nice to also have working tilt environments on our release branches (best effort). I wonder if we should make similar changes to our other release branches /lgtm |
LGTM label has been added. Git tree hash: 294977149de3454ecc64e02bf8df25a771321ed1
|
/approve @killianmuldoon can you open similar PRs against the other supported branches? Just keep tilt best-effort working |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.5 |
/cherry-pick release-1.4 |
@killianmuldoon: new pull request created: #9072 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@killianmuldoon: new pull request created: #9073 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Change the base image used in the Tiltfile for debug images to golang. This change fixes an error with the output:
Still not sure of the root cause of the new error - but given that this is only used in our dev setup we can safely make this change.