Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.4] 🐛 requeue KCP object if ControlPlaneComponentsHealthyCondition is not yet true #9036

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #9032

/assign sbueringer

@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Jul 21, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 21, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 20d1e24e82b4c020a135f45e7978b3fb70e1775a

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2023
@chrischdi
Copy link
Member

/hold

as the issue comes only with PreFlight checks which are there beginning with v1.5 🤔

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2023
@chrischdi
Copy link
Member

/retest

@killianmuldoon
Copy link
Contributor

I think the assessment was that this issue does happen on 1.3 and 1.4 - but it's surfaced by the preflight checks in our e2e tests. With preflight checks off this issue still occurs and reconciliation is still slower than it should be, but it doesn't block the reconciliation of MachineSets.

@chrischdi
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 21, 2023
@k8s-ci-robot k8s-ci-robot merged commit 120a6d9 into kubernetes-sigs:release-1.4 Jul 21, 2023
@sbueringer
Copy link
Member

/approve

@killianmuldoon
Copy link
Contributor

/area provider/control-plane-kubeadm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants