-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Label selector conditional reconciler #9003
✨ Label selector conditional reconciler #9003
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
45af36e
to
e44db26
Compare
e44db26
to
549d567
Compare
8ae74db
to
549d567
Compare
…ession value is set
@Danil-Grigorev: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Closing this due to inactivity, feel free to reopen when ready to discuss again. /close |
@vincepri: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This implementation may allow users to optionally reconcile resources based on
watch-expression
flag. With the flag in place, provided label selector expression will evaluate each resource preventing reconciliation. Based on https://kubernetes.io/docs/concepts/overview/working-with-objects/labels/#set-based-requirementExamples may include ignoring resources marked by a label:
Which issue(s) this PR fixes
This implementation covers the basic scenario of
==
and!=
,in
andnotin
on resource labels.Fixes #7775