-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 in-memory provider: add apiserver & etcd metrics #8962
🌱 in-memory provider: add apiserver & etcd metrics #8962
Conversation
63d75a0
to
ea9a522
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, but let's wait for #8938 to merge so we can add metrics for MoveLeader and MemberRemove
/hold
ea9a522
to
95c2154
Compare
@fabriziopandini done, ptal :) |
/hold cancel |
LGTM label has been added. Git tree hash: 9377f05ab936b4fbfb634ee7f96e108b6b43fae0
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area provider/infrastructure-in-memory |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #