Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 KCP: Log the reason of a Machine rollout #8959

Merged
merged 1 commit into from
Jul 7, 2023
Merged

🌱 KCP: Log the reason of a Machine rollout #8959

merged 1 commit into from
Jul 7, 2023

Conversation

sbueringer
Copy link
Member

What this PR does / why we need it:
This PR extends KCP to also log the reason why we trigger a rollout.

Would be nice if it could make it into the release, but if it doesn't it's okay :)

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #5557

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 4, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 4, 2023
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

/assign @fabriziopandini @killianmuldoon

fabriziopandini
fabriziopandini reviewed Jul 4, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a nice improvement, I'm only proposing some changes in messages, but nothing blocking

controlplane/kubeadm/internal/controllers/controller.go Show resolved Hide resolved
controlplane/kubeadm/internal/filters.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/filters.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/filters.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/filters.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/filters.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/filters.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/filters.go Outdated Show resolved Hide resolved
@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member Author

Not sure what GitHub is doing. I pushed an additional commit on my branch: https://github.com/sbueringer/cluster-api/commits/pr-improve-kcp-logging

Doesn't seem to show up here. I'll check later again

@sbueringer sbueringer closed this Jul 5, 2023
@sbueringer sbueringer reopened this Jul 5, 2023
@sbueringer
Copy link
Member Author

Fun re-opening the PR helped, now the 2nd commit shows up

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

g-gaston
g-gaston reviewed Jul 6, 2023
View reviewed changes
Copy link
Contributor

@g-gaston g-gaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just few nits, otherwise good to go

controlplane/kubeadm/internal/filters.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/filters.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/filters.go Outdated Show resolved Hide resolved
controlplane/kubeadm/internal/filters.go Show resolved Hide resolved
@sbueringer sbueringer force-pushed the pr-improve-kcp-logging branch from 59ed6fe to 2e4f6d9 Compare July 6, 2023 18:32
@sbueringer
Copy link
Member Author

Thx for the reviews. Should be all addressed

@sbueringer
Copy link
Member Author

@killianmuldoon @fabriziopandini PTAL when you have some time, would be great to get this merged before the code freeze so we can profit from the improved logging when debugging :)

killianmuldoon
killianmuldoon reviewed Jul 7, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really great improvement - thanks for working on it.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 7, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f3574db4a264462969b1d8ca898c9d4090a201b0

@fabriziopandini
Copy link
Member

Nice improvement!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6ce4942 into kubernetes-sigs:main Jul 7, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Jul 7, 2023
@johannesfrey
Copy link
Contributor

/area provider/control-plane-kubeadm

@k8s-ci-robot k8s-ci-robot added the area/provider/control-plane-kubeadm Issues or PRs related to KCP label Jul 11, 2023
@sbueringer sbueringer deleted the pr-improve-kcp-logging branch July 11, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@g-gaston g-gaston g-gaston left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

Assignees

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/control-plane-kubeadm Issues or PRs related to KCP cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

KubeadmControlPlane should provide an explanation when it decides a Machine should be replaced
6 participants
@sbueringer @k8s-ci-robot @fabriziopandini @johannesfrey @g-gaston @killianmuldoon