🐛 Fix deprecation marker for RolloutAfter #8924
Conversation
Signed-off-by: killianmuldoon <[email protected]>
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
|
Thx! /lgtm /cherry-pick release-1.4 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 4e65d120aee65a6c7116ebe1a39e05f1ef2d6690
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
@sbueringer: new pull request created: #8925 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/area documentation |
Fix the deprecation marker for Cluster
.spec.Topology.RolloutAfterso it is correctly picked up by go tooling. Deprecation markers should always be in a new paragraph block in the godoc comment.I went through all of our deprecation markers and this was the only one I found that didn't meet the standard.