-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 cluster/topology: use cached MD list in get current state #8922
🌱 cluster/topology: use cached MD list in get current state #8922
Conversation
/assign @fabriziopandini @killianmuldoon @ykakarap /hold |
/hold cancel CI green |
aeac8a7
to
6335950
Compare
@fabriziopandini PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes make sense to me - it makes the code flow more complex though. I wonder if we can follow up (after another round of performance fixes) by documenting a list of where we actually use the APIReader, and best practices for it.
/lgtm |
LGTM label has been added. Git tree hash: 8cd41c60f6f9046f6f2612b6f12d84b1a26c1d5b
|
/lgtm +1 to take some time to document what we are learning after we finish this iteration |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sounds good to document the findings once we have time |
/area clusterclass |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Related #8814