Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Enable configuring the kubernetes rest client timeout for draining nodes #8917

Merged
merged 1 commit into from
Jul 5, 2023
Merged

✨ Enable configuring the kubernetes rest client timeout for draining nodes #8917

merged 1 commit into from
Jul 5, 2023

Conversation

cnmcavoy
Copy link
Contributor

What this PR does / why we need it:
Allows configuring the kubernetes client configuration timeout used by the machine controller when draining nodes.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #8864

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jun 26, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @cnmcavoy. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 26, 2023
@cnmcavoy cnmcavoy mentioned this pull request Jun 26, 2023
Closed
sbueringer
sbueringer reviewed Jun 27, 2023
View reviewed changes
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
controllers/alias.go Outdated Show resolved Hide resolved
@cnmcavoy cnmcavoy force-pushed the cnmcavoy/configurable-kube-timeout branch from fad64b3 to 1440b5b Compare June 28, 2023 19:01
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 28, 2023
sbueringer
sbueringer reviewed Jun 29, 2023
View reviewed changes
main.go Outdated Show resolved Hide resolved
@fabriziopandini
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 29, 2023
@cnmcavoy cnmcavoy force-pushed the cnmcavoy/configurable-kube-timeout branch from 1440b5b to a5811de Compare June 30, 2023 18:44
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 30, 2023
@sbueringer
Copy link
Member

Thank you!

/lgtm

/assign @fabriziopandini @enxebre

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e822208369eb58d05f21770a9df629af7b56bc5d

fabriziopandini
fabriziopandini reviewed Jul 3, 2023
View reviewed changes
main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@enxebre
Copy link
Member

enxebre commented Jul 4, 2023

/lgtm
pending Fabrizio's comments

@sbueringer
Copy link
Member

@cnmcavoy Just fyi. We have a code freeze for v1.5 coming up next week on Tuesday. I think if we can get the last nits addressed we'll get this PR merged in time for the release.

@cnmcavoy cnmcavoy force-pushed the cnmcavoy/configurable-kube-timeout branch from a5811de to e222edf Compare July 5, 2023 15:12
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2023
@sbueringer
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 5, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5ab9c78679124acced1ce7881a0a95b02bb0eac6

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2091c44 into kubernetes-sigs:main Jul 5, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Jul 5, 2023
@killianmuldoon
Copy link
Contributor

/area machine

@k8s-ci-robot k8s-ci-robot added the area/machine Issues or PRs related to machine lifecycle management label Jul 5, 2023
@cnmcavoy cnmcavoy mentioned this pull request Sep 21, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@enxebre enxebre Awaiting requested review from enxebre

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@enxebre enxebre

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machine Issues or PRs related to machine lifecycle management cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

Allow configuring kube client timeouts
6 participants
@cnmcavoy @k8s-ci-robot @fabriziopandini @sbueringer @enxebre @killianmuldoon