🌱 CAPIM: Enable update for coreDNS and kube-proxy #8899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
size/M
killianmuldoon
commented
Jun 21, 2023
killianmuldoon
commented
Jun 21, 2023
killianmuldoon
force-pushed
the
pr-in-memory-update-coredns-kubeproxy
branch
from
77a7d55 to
18bc71b
Compare
k8s-ci-robot
added
size/L
killianmuldoon
commented
Jun 22, 2023
There was a problem hiding this comment.
This PR only covers the base case for these functions now.
Not covered:
- handling for clusterRole and v1.22 migration (not sure how long we have to keep this code around, but there's a lot of complexity around version checking and probably not worth it here.
- handling for upgrades of coreDNS - will be done under the upgrades work.
killianmuldoon
force-pushed
the
pr-in-memory-update-coredns-kubeproxy
branch
from
18bc71b to
dcb952e
Compare
killianmuldoon
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
killianmuldoon
force-pushed
the
pr-in-memory-update-coredns-kubeproxy
branch
from
dcb952e to
fc1c954
Compare
test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go
Outdated
Show resolved
Hide resolved
test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go
Outdated
Show resolved
Hide resolved
test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go
Outdated
Show resolved
Hide resolved
test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go
Outdated
Show resolved
Hide resolved
killianmuldoon
force-pushed
the
pr-in-memory-update-coredns-kubeproxy
branch
from
fc1c954 to
5860700
Compare
|
/lgtm cc @sbueringer |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 2785c18e769f14a3e42b5bcb9376e8151f217214
|
sbueringer
reviewed
Jun 23, 2023
test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go
Outdated
Show resolved
Hide resolved
test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go
Outdated
Show resolved
Hide resolved
test/infrastructure/inmemory/templates/clusterclass-in-memory-quick-start.yaml
Show resolved
Hide resolved
killianmuldoon
force-pushed
the
pr-in-memory-update-coredns-kubeproxy
branch
from
5860700 to
d9203ab
Compare
k8s-ci-robot
removed
the
lgtm
killianmuldoon
force-pushed
the
pr-in-memory-update-coredns-kubeproxy
branch
from
d9203ab to
6b5e7cf
Compare
sbueringer
reviewed
Jun 23, 2023
test/infrastructure/inmemory/internal/controllers/inmemorymachine_controller.go
Outdated
Show resolved
Hide resolved
killianmuldoon
force-pushed
the
pr-in-memory-update-coredns-kubeproxy
branch
2 times, most recently
from
b3eed05 to
8b13350
Compare
Signed-off-by: killianmuldoon <[email protected]>
killianmuldoon
force-pushed
the
pr-in-memory-update-coredns-kubeproxy
branch
from
8b13350 to
c85ce8e
Compare
|
/lgtm /hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 2b1a0055a4d28e15c0ec436dc00cf1195aa98e59
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/area provider/infrastructure-in-memory (doesn't exist yet) |
k8s-ci-robot
added
the
area/provider/infrastructure-in-memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the CAPIM to respond to calls to update coreDNS and kube-proxy.
Part of #8814