🌱 test/e2e/in-memory: improve performance by fixing locking issues #8895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/L
sbueringer
commented
Jun 21, 2023
| key, err := certs.NewPrivateKey() | ||
| var key *rsa.PrivateKey | ||
|
|
||
| func init() { |
There was a problem hiding this comment.
Generating a private key is slow. Now we only do it once on startup and share it across clusters
sbueringer
commented
Jun 21, 2023
| m.log.Error(startErr, "Failed to start WorkloadClusterListener", "listenerName", wclName, "address", wcl.Address()) | ||
| // Wait until the sever is working. | ||
| var pollErr error | ||
| err = wait.PollUntilContextTimeout(context.TODO(), 10*time.Millisecond, 1*time.Second, true, func(ctx context.Context) (done bool, err error) { |
There was a problem hiding this comment.
With this change we wait until the listener serves (at least a tls handshake). This is quicker than always waiting 100 ms
Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-im-fix-mux
branch
from
3f136e3 to
245e305
Compare
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 7f6f978ad91e61315f0694c16b486c0dfb11666f
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/area provider/infrastructure-in-memory |
k8s-ci-robot
added
the
area/provider/infrastructure-in-memory
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Currently the in-memory provider gets slow if we're getting to very high cluster numbers.
Basically the problem was that when we create a new apiserver we locked the global lock. This was slowing down all requests served by the apiserver because that lock is used during every tls handshake and in every request (to get the resourceGroup).
Kudos to @fabriziopandini for the collaboration on this.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Related to #8814