-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Use rest config from ClusterCacheTracker consistently #8894
🌱 Use rest config from ClusterCacheTracker consistently #8894
Conversation
/assign @fabriziopandini @killianmuldoon @ykakarap |
38b680e
to
970ae7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 1f2f78a24ac1ebf0fab830ac8919ac786926ca93
|
Signed-off-by: Stefan Büringer buringerst@vmware.com
970ae7f
to
a37f57d
Compare
Had to fix a unit test |
/lgtm |
LGTM label has been added. Git tree hash: 9f7bfc72f017db5c53c61c443de51f2dd33da9ef
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/hold
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Feel free to remove /hold when you're happy this is ready. |
/lgtm @sbueringer one question: |
Sounds reasonable to me at a first glance. I would prefer not having to maintain them anymore. But I don't know who is using them and maybe they don't want to use the CCT. For example in a CLI folks might just want to get a rest config for a cluster and then don't want to run an entire CCT for that (Btw NewClusterClient is not used at all anymore in core CAPI) |
/hold cancel |
/area clustercachetracker |
Signed-off-by: Stefan Büringer buringerst@vmware.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #