-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.3] 🐛 Use known kindest/node image versions by sha for e2e upgrade tests #8869
[release-1.3] 🐛 Use known kindest/node image versions by sha for e2e upgrade tests #8869
Conversation
Signed-off-by: killianmuldoon <[email protected]>
/test pull-cluster-api-e2e-full-release-1-3 |
/lgtm /hold |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
LGTM label has been added. Git tree hash: 5a210d9f068a66ebbfe0c0ac5c5a36bba5bf9cc2
|
/close This approach isn't going to work. Will look to also revert this on main. |
@killianmuldoon: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@killianmuldoon: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
New changes are detected. LGTM label has been removed. |
/test pull-cluster-api-e2e-full-release-1-3 |
46f6a33
to
a19a288
Compare
Signed-off-by: killianmuldoon <[email protected]>
a19a288
to
5b49ef6
Compare
/test pull-cluster-api-e2e-full-release-1-3 |
/close Closing for now as these tests are still green due to using an older version of the KIND images. We'll have to revive this PR if we need to bump those kind images in future. |
@killianmuldoon: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Pin the kind image used in the clusterctl upgrade tests to a known good version which works with CAPD and KIND v0.19.0. These images are the ones suggested in the KIND v0.19.0 release at https://github.com/kubernetes-sigs/kind/releases/tag/v0.19.0
This should fix test failures related to #8815