Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.3] 🐛 Use known kindest/node image versions by sha for e2e upgrade tests #8869

Conversation

killianmuldoon
Copy link
Contributor

Pin the kind image used in the clusterctl upgrade tests to a known good version which works with CAPD and KIND v0.19.0. These images are the ones suggested in the KIND v0.19.0 release at https://github.com/kubernetes-sigs/kind/releases/tag/v0.19.0

This should fix test failures related to #8815

@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone Jun 16, 2023
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 16, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jun 16, 2023
@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-release-1-3

@sbueringer
Copy link
Member

/lgtm
/approve

/hold
for CI

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 16, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5a210d9f068a66ebbfe0c0ac5c5a36bba5bf9cc2

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2023
@killianmuldoon
Copy link
Contributor Author

/close

This approach isn't going to work. Will look to also revert this on main.

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: Closed this PR.

In response to this:

/close

This approach isn't going to work. Will look to also revert this on main.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor Author

/reopen

@k8s-ci-robot k8s-ci-robot reopened this Jun 19, 2023
@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 19, 2023
@k8s-ci-robot k8s-ci-robot requested a review from sbueringer June 19, 2023 09:41
@k8s-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 19, 2023
@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-release-1-3

@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jun 19, 2023
@killianmuldoon killianmuldoon force-pushed the pr-1.3-kind-image-sha branch from 46f6a33 to a19a288 Compare June 19, 2023 09:52
@killianmuldoon killianmuldoon force-pushed the pr-1.3-kind-image-sha branch from a19a288 to 5b49ef6 Compare June 19, 2023 09:53
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 19, 2023
@killianmuldoon
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-release-1-3

@killianmuldoon
Copy link
Contributor Author

/close

Closing for now as these tests are still green due to using an older version of the KIND images. We'll have to revive this PR if we need to bump those kind images in future.

@k8s-ci-robot
Copy link
Contributor

@killianmuldoon: Closed this PR.

In response to this:

/close

Closing for now as these tests are still green due to using an older version of the KIND images. We'll have to revive this PR if we need to bump those kind images in future.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants