Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 optimize reconcileInterruptibleNodeLabel of machine controller #8852

Merged
merged 1 commit into from
Jun 22, 2023
Merged

🌱 optimize reconcileInterruptibleNodeLabel of machine controller #8852

merged 1 commit into from
Jun 22, 2023

Conversation

ykakarap
Copy link
Contributor

@ykakarap ykakarap commented Jun 14, 2023 •
edited
Loading

What this PR does / why we need it:

This PR optimized the machine controller by dropping unwantedexternal.Get calls. Since the external objects are unstructured these calls are generally not cached.

Therefore these calls become expensive for each reconcile. This PR optimizes by storing the result of external.Get calls so that other parts of the controllers do not have to perform this expensive and redundant call.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Part of #8814

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 14, 2023
@sbueringer sbueringer mentioned this pull request Jun 14, 2023
Open
27 tasks
@ykakarap ykakarap force-pushed the pr-optimizie-reconcileInterruptibleNodeLabel branch from 3b3818a to 2119e28 Compare June 21, 2023 04:25
@ykakarap ykakarap changed the title 🌱 [WIP][DO_NOT_REVIEW] optimize reconcileInterruptibleNodeLabel of machine controller 🌱 optimize reconcileInterruptibleNodeLabel of machine controller Jun 21, 2023
@ykakarap
Copy link
Contributor Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@ykakarap: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main
  • /test pull-cluster-api-e2e-full-dualstack-and-ipv6-main
  • /test pull-cluster-api-e2e-full-main
  • /test pull-cluster-api-e2e-informing-main
  • /test pull-cluster-api-e2e-mink8s-main
  • /test pull-cluster-api-e2e-scale-main-experimental
  • /test pull-cluster-api-e2e-workload-upgrade-1-26-1-27-krte-exp
  • /test pull-cluster-api-e2e-workload-upgrade-1-26-1-27-kubekins-exp
  • /test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main
  • /test pull-cluster-api-test-mink8s-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-informing-main
  • pull-cluster-api-e2e-main
  • pull-cluster-api-test-main
  • pull-cluster-api-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

/test pull-cluster-api-e2e-full-main

sbueringer
sbueringer reviewed Jun 21, 2023
View reviewed changes
Copy link
Member

@sbueringer sbueringer left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good thank you, a few smaller findings

internal/controllers/machine/machine_controller.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_noderef.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_noderef.go Outdated Show resolved Hide resolved
internal/controllers/machine/machine_controller_noderef.go Show resolved Hide resolved
@ykakarap ykakarap force-pushed the pr-optimizie-reconcileInterruptibleNodeLabel branch from 2119e28 to baa7972 Compare June 22, 2023 03:09
@ykakarap
Copy link
Contributor Author

/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member

Thank you!!

/lgtm

/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a78b0a6062d352306663dda47966b5238307dcc8

@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit e8eb540 into kubernetes-sigs:main Jun 22, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Jun 22, 2023
@sbueringer sbueringer mentioned this pull request Jun 23, 2023
Closed
killianmuldoon
killianmuldoon reviewed Jun 27, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/area machine

@k8s-ci-robot k8s-ci-robot added the area/machine Issues or PRs related to machine lifecycle management label Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@fabriziopandini fabriziopandini fabriziopandini left review comments

@sbueringer sbueringer sbueringer left review comments

@enxebre enxebre Awaiting requested review from enxebre

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machine Issues or PRs related to machine lifecycle management cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@ykakarap @k8s-ci-robot @sbueringer @fabriziopandini @killianmuldoon