Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 ClusterCacheTracker: Stop pod caching when checking workload cluster #8850

Merged

Conversation

killianmuldoon
Copy link
Contributor

Check if the clusterCacheTracker is running on the workload cluster using an uncached client. Previously Pods were being cached by the controller runtime client which could cause unnecessarily high memory usage.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 13, 2023
@sbueringer sbueringer mentioned this pull request Jun 13, 2023
27 tasks
@sbueringer
Copy link
Member

Really really nice catch and neat fix :) !! This had pretty high impact on environments with a high number of clusters / pods.

cc @fabriziopandini

/lgtm
/approve
(approving directly as the fix is straightforward and I'll use this improvement directly in further scale testing)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 54b6516e247ec12b02464b40678a388d88153f49

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2023
@sbueringer sbueringer changed the title 🐛 Stop pod caching when checking workload cluster 🐛 ClusterCacheTracker: Stop pod caching when checking workload cluster Jun 14, 2023
@sbueringer sbueringer added the area/clustercachetracker Issues or PRs related to the clustercachetracker label Jun 14, 2023
@fabriziopandini
Copy link
Member

💯 great catch, this saves us from caching Pods for all the workload clusters!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [fabriziopandini,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 27195c0 into kubernetes-sigs:main Jun 14, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Jun 14, 2023
@killianmuldoon
Copy link
Contributor Author

/area clustercachetracker

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clustercachetracker Issues or PRs related to the clustercachetracker cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants