-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Add minor release prefix for title polishing #8802
📖 Add minor release prefix for title polishing #8802
Conversation
@@ -332,7 +332,7 @@ The goal of this task to make the book for the current release available under e | |||
7. Write highlights section based on the initial release notes doc. | |||
8. Add the Kubernetes version support section and pay close attention to set the correct versions here. | |||
<br>**Note**: Check our [Kubernetes support policy](https://cluster-api.sigs.k8s.io/reference/versions.html#supported-kubernetes-versions) in the CAPI book. In case of doubt, reach out to the current release lead. | |||
9. Modify `Changes since v1.x.y` to `Changes since v1.x` | |||
9. **For minor releases** Modify `Changes since v1.x.y` to `Changes since v1.x` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to check @sbueringer - do yo know if this was intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The previous version or the whole point?
I think overall we should just end up with something that makes sense in the release notes :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry - I meant the previous version. This isn't something we've been actively doing in any of the patch releases, but was rightly pointed out by @johannesfrey in the release call today.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it. Yeah for patch releases we want "changes since "last patch release""
/lgtm |
LGTM label has been added. Git tree hash: ee149f448d2cae67aa69358059dc6a589faf4895
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
It looks like this step is only relevant for minor releases.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
/area documentation
Johannes Frey <[email protected]>, Mercedes-Benz Tech Innovation GmbH (Provider Information)