Record machine sync error event #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/lgtm |
k8s-ci-robot
added
the
lgtm
vincepri
reviewed
Apr 8, 2019
| @@ -251,6 +251,10 @@ func (r *ReconcileMachineSet) reconcile(ctx context.Context, machineSet *cluster | |||
| return reconcile.Result{}, errors.Wrap(err, "failed to update machine set status") | |||
| } | |||
|
|
|||
| if syncErr != nil { | |||
| return reconcile.Result{}, errors.Wrapf(syncErr, "failed to sync machines") | |||
There was a problem hiding this comment.
Any reason we shouldn't check the error just after the call to syncReplicas?
There was a problem hiding this comment.
@vincepri so that machineset status status could get updated and along with error message in the events, user could have latest stats.
k8s-ci-robot
removed
the
lgtm
vikaschoudhary16
force-pushed
the
upstream-record-syncerr
branch
from
417751a to
7123307
Compare
vincepri
approved these changes
Apr 9, 2019
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vikaschoudhary16, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
detiber
pushed a commit
to detiber/cluster-api
that referenced
this pull request
May 2, 2019
k8s-ci-robot
pushed a commit
that referenced
this pull request
May 2, 2019
* Update CRDs (#863) Generated with `make generate` * fix various shell bugs (#868) * fix errors in scripts/ci-build.gitsh * fix errors in scripts/ci-integration.sh * fix errors in scripts/ci-is-vendor-in-sync.sh * fix errors in scripts/ci-make.sh * fix errors in scripts/ci-test.sh * removed unused variables from scripts/fetch_ext_bins.sh * fix errors in hack/update-bazel.sh * fix errors in hack/verify_clientset.sh * use gnu sed on all platforms (#867) * Fix error message in getCluster (#871) Previously it was showing 'Machine foo in namespace "cluster.k8s.io/cluster-name" doesn't specify "k8s-machine-api" label, assuming nil cluster' * minikube: use --profile instead of --p (#875) It was reported that "minikube start" fails: minikube start --bootstrapper=kubeadm --p=clusterapi Error: unknown flag: --p From "minikube start --help": -p, --profile string Use --profile in minikube.go as --p does not work. The alternative is -p. * nit: fix log to replace Creating with Preparing (#872) saw this log with following flag --bootstrap-cluster-kubeconfig /root/.kube/config I0403 17:32:28.339021 31615 createbootstrapcluster.go:27] Creating bootstrap cluster actually we are reusing ,not creating * Record machine sync error event (#880) * make clusterapi wait timeout configurable (#865) add an environment to make timeout configurable for timeoutMachineReady * Update klog to 0.3.0 release (#890) Signed-off-by: Vince Prignano <[email protected]> * Add missing namespace to Get function (#896) * Add NodeName to Machine's additionalPrinterColumns (#895) Because it is useful to cross-reference between Machines and Nodes. Set priority to >0 so that node names will only be displayed in `-o wide` because the names are often quite long. * additionalPrinterColumns for Machine, added correctly. (#897) Co-authored-by: Danny Berger <[email protected]> * Normalize clusterctl options to underscores (#899) Matches current conventions and implementation of kubectl. This change does not include warning messages when using the previous, underscore option names, but it does recognize those names. Co-authored-by: Leah Hanson <[email protected]> * Update manager-role ClusterRole (#901) * Update Go 1.12 (#898) * Update Go 1.12 Signed-off-by: Vince Prignano <[email protected]> * update Signed-off-by: Vince Prignano <[email protected]> * Update OWNERS_ALIASES and SECURITY_CONTACTS (#884) * Update OWNERS_ALIASES and SECURITY_CONTACTS * Add davidewatson to cluster-api-admins * Clarify log message for machine-controller isDeleteAllowed (#905) Users have noted that this log message is confusing and does not lead to a clear path forward when deleting this machine. This commit makes it clear that the machine will not be deleted. * Clarify MachineDeployment watchers' comments (#887) Signed-off-by: Vince Prignano <[email protected]> * Simplify util.ParseMachinesYaml (#909) Signed-off-by: Vince Prignano <[email protected]> * Add support for passing namespace cmdline flag to the manager (#914) * Bump kubectl version to v1.13.2 in ci (#923) kubectl v1.10.2 does not compatible with cluster v1.14.x anymore Signed-off-by: Hui Luo <[email protected]> * Add /status to MachineSet and MachineDeployment kubebuilder directives (#922) Signed-off-by: Vince Prignano <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any errors encountered while reconciling machines should be reported as events at the machineset controller object.
What this PR does / why we need it:
Fixes the recording of machine sync errors. Currently if machineset faces any error which reconciling machines, this error will not be reported at machineset object.
This PR fixes above issue.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1696407
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: