-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 update MachineSet PreflightChecks documentation #8775
📖 update MachineSet PreflightChecks documentation #8775
Conversation
docs/book/src/tasks/experimental-features/machineset-preflight-checks.md
Show resolved
Hide resolved
docs/book/src/tasks/experimental-features/machineset-preflight-checks.md
Outdated
Show resolved
Hide resolved
docs/book/src/tasks/experimental-features/machineset-preflight-checks.md
Outdated
Show resolved
Hide resolved
docs/book/src/tasks/experimental-features/machineset-preflight-checks.md
Outdated
Show resolved
Hide resolved
docs/book/src/tasks/experimental-features/machineset-preflight-checks.md
Outdated
Show resolved
Hide resolved
docs/book/src/tasks/experimental-features/machineset-preflight-checks.md
Outdated
Show resolved
Hide resolved
docs/book/src/tasks/experimental-features/machineset-preflight-checks.md
Outdated
Show resolved
Hide resolved
docs/book/src/tasks/experimental-features/machineset-preflight-checks.md
Outdated
Show resolved
Hide resolved
e69d62e
to
ea8bb5c
Compare
/lgtm /assign @fabriziopandini |
LGTM label has been added. Git tree hash: 4744d4428b6e4615f45643e661b3219e54d0dd02
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just few nits, great work!
docs/book/src/tasks/experimental-features/machineset-preflight-checks.md
Outdated
Show resolved
Hide resolved
docs/book/src/tasks/experimental-features/machineset-preflight-checks.md
Show resolved
Hide resolved
docs/book/src/tasks/experimental-features/machineset-preflight-checks.md
Outdated
Show resolved
Hide resolved
ea8bb5c
to
253314f
Compare
Thx! /lgtm |
LGTM label has been added. Git tree hash: 2bdc0a4ac6008b942c69b0a3cf8ea2e3fa58b77d
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area documentation |
What this PR does / why we need it:
This PR updates the documentation of the
MachineSetPreflightChecks
feature gate.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #8717