Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump golang version (1.20.3 -> 1.20.4) #8749

Merged
merged 1 commit into from
May 30, 2023
Merged

🌱 Bump golang version (1.20.3 -> 1.20.4) #8749

merged 1 commit into from
May 30, 2023

Conversation

Prajyot-Parab
Copy link
Contributor

What this PR does / why we need it:

  • Bump golang version (1.20.3 -> 1.20.4)

This version update has 3 security fixes for go:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 25, 2023
killianmuldoon
killianmuldoon reviewed May 25, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 25, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cf99466dddb1ebe13bd8e5075dcdaf1febf4c982

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. and removed cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 26, 2023
@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2023
@sbueringer
Copy link
Member

/check-cla

1 similar comment
@fabriziopandini
Copy link
Member

/check-cla

@fabriziopandini
Copy link
Member

@Prajyot-Parab it seems there is something not working with your CLA (might be just a temporary glitch that can be fixed by force pushing).

@Prajyot-Parab
Copy link
Contributor Author

/check-cla

@Prajyot-Parab
Copy link
Contributor Author

/easycla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 30, 2023
@Prajyot-Parab
Copy link
Contributor Author

@Prajyot-Parab it seems there is something not working with your CLA (might be just a temporary glitch that can be fixed by force pushing).

everything is fine on my end, seems temporary issue, fixed it.

@Prajyot-Parab
Copy link
Contributor Author

/test all

@sbueringer
Copy link
Member

/retest

1 similar comment
@Prajyot-Parab
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit f88bdd7 into kubernetes-sigs:main May 30, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone May 30, 2023
@k8s-ci-robot
Copy link
Contributor

@Prajyot-Parab: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-e2e-informing-main 1ac7a79 link false /test pull-cluster-api-e2e-informing-main

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@johannesfrey
Copy link
Contributor

/area ci

@k8s-ci-robot k8s-ci-robot added the area/ci Issues or PRs related to ci label Jun 16, 2023
@johannesfrey
Copy link
Contributor

/remove-area ci
/area dependency

@k8s-ci-robot k8s-ci-robot added area/dependency Issues or PRs related to dependency changes and removed area/ci Issues or PRs related to ci labels Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@enxebre enxebre Awaiting requested review from enxebre

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
6 participants
@Prajyot-Parab @k8s-ci-robot @sbueringer @fabriziopandini @johannesfrey @killianmuldoon