🌱 Pin delve to match go minor version #8725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: killianmuldoon <[email protected]>
k8s-ci-robot
added
area/devtools
k8s-ci-robot
added
the
size/XS
sbueringer
reviewed
May 23, 2023
| @@ -166,8 +166,9 @@ def load_provider_tiltfiles(): | |||
| tilt_helper_dockerfile_header = """ | |||
| # Tilt image | |||
| FROM golang:1.20.3 as tilt-helper | |||
| # Install delve. Note this should be kept in step with the Go release minor version. | |||
| RUN go install github.com/go-delve/delve/cmd/[email protected] | |||
There was a problem hiding this comment.
Do you know why this works? The tag seems to be v1.20.0 (or v1.20.1 / v1.20.2)
There was a problem hiding this comment.
From https://go.dev/ref/mod#version-queries
A version query may be one of the following:
- A fully-specified semantic version, such as v1.2.3, which selects a specific version. See Versions for syntax.
- A semantic version prefix, such as v1 or v1.2, which selects the highest available version with that prefix.
- A semantic version comparison, such as <v1.2.3 or >=v1.5.6, which selects the nearest available version to the comparison target (the lowest version for > and >=, and the highest version for < and <=).
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5918b5f330b97fa589cede8157397c40415d8d54
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pin delve to use Golang v1.20.
Note: This version should be kept in line with the Go minor version used.
Fixes #8723
/area devtools