Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 CAPD: change the haproxy entrypoint to prevent getting stopped immediately after start #8685

Merged
merged 1 commit into from
May 24, 2023
Merged

🐛 CAPD: change the haproxy entrypoint to prevent getting stopped immediately after start #8685

merged 1 commit into from
May 24, 2023

Conversation

chrischdi
Copy link
Member

@chrischdi chrischdi commented May 17, 2023 •
edited
Loading

What this PR does / why we need it:

For more context see #8641.

We came to the conclusion that we can drop the -sf 7 arguments when starting haproxy.
This seem to be able to exit the haproxy process immediately after start, resulting in not-running lb container and by that in flaky tests.

Kudos to @killianmuldoon for testing the updated arguments to see if config updating still works.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

Tries to fix #8641

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 17, 2023
@chrischdi
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@chrischdi: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-main
  • /test pull-cluster-api-e2e-main
  • /test pull-cluster-api-test-main
  • /test pull-cluster-api-test-mink8s-main
  • /test pull-cluster-api-verify-main

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-main
  • /test pull-cluster-api-e2e-full-dualstack-ipv6-main
  • /test pull-cluster-api-e2e-full-main
  • /test pull-cluster-api-e2e-informing-ipv6-main
  • /test pull-cluster-api-e2e-informing-main
  • /test pull-cluster-api-e2e-scale-main-experimental
  • /test pull-cluster-api-e2e-workload-upgrade-1-27-latest-main

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-main
  • pull-cluster-api-build-main
  • pull-cluster-api-e2e-informing-ipv6-main
  • pull-cluster-api-e2e-informing-main
  • pull-cluster-api-e2e-main
  • pull-cluster-api-test-main
  • pull-cluster-api-test-mink8s-main
  • pull-cluster-api-verify-main

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@chrischdi chrischdi force-pushed the pr-reproduce-lb-ct-issue branch from 1fb425b to 294f89d Compare May 17, 2023 15:25
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 17, 2023
@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 17, 2023
@chrischdi chrischdi force-pushed the pr-reproduce-lb-ct-issue branch from 0b76bc8 to ed2c3a7 Compare May 17, 2023 16:02
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 17, 2023
@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

3 similar comments
@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main

@chrischdi chrischdi force-pushed the pr-reproduce-lb-ct-issue branch from 4baad7d to 053cc07 Compare May 22, 2023 07:53
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 22, 2023
@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-full-main
/test pull-cluster-api-e2e-informing-main

@chrischdi
CAPD: change the haproxy entrypoint to prevent getting stopped immedi…
a0c371c 
…ately after start

With this PR CAPD uses a customized entrypoint to start the haproxy lb container.
Compared to the entrypoint built-in into the image, it drops the arguments `-sf 7`.
This argument seems to result in stopping the container immediately on
hard to reproduce circumstances.
@chrischdi chrischdi force-pushed the pr-reproduce-lb-ct-issue branch from 053cc07 to a0c371c Compare May 24, 2023 14:55
@chrischdi chrischdi changed the title 🐛 [WIP] DONOTREVIEW try to reproduce flake #8641 🐛 CAPD: change the haproxy entrypoint to prevent getting stopped immediately after start May 24, 2023
@chrischdi
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@killianmuldoon
Copy link
Contributor

/test pull-cluster-api-e2e-full-main

Let's give it a full run before merging

@chrischdi
Copy link
Member Author

  • Rebased
  • changed according review
  • adjusted title
  • adjusted description of the PR to be more friendly for future readers

@killianmuldoon
Copy link
Contributor

/hold

For e2e-full

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2023
@killianmuldoon
Copy link
Contributor

/retest

killianmuldoon
killianmuldoon reviewed May 24, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d19b928ef2c5184d0288732a34da46402f6852cf

@sbueringer
Copy link
Member

/approve
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 24, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 12f1de5 into kubernetes-sigs:main May 24, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone May 24, 2023
@chrischdi chrischdi deleted the pr-reproduce-lb-ct-issue branch May 24, 2023 17:10
@killianmuldoon
Copy link
Contributor

/cherry-pick release-1.3

@killianmuldoon
Copy link
Contributor

/cherry-pick release-1.4

@killianmuldoon
Copy link
Contributor

We should hold the cherry-picks until we have some signal that this works - but I'd prefer to have them in the queue as a reminder.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 24, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: new pull request created: #8741

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: new pull request created: #8742

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 24, 2023
Merged
@johannesfrey
Copy link
Contributor

/area provider/infrastructure-docker

@k8s-ci-robot k8s-ci-robot added the area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider label Jun 5, 2023
@killianmuldoon killianmuldoon mentioned this pull request Jun 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@ykakarap ykakarap Awaiting requested review from ykakarap

Assignees

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/infrastructure-docker Issues or PRs related to the docker infrastructure provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.

Tests failing with "No Control Plane machines came into existence."
6 participants
@chrischdi @k8s-ci-robot @killianmuldoon @sbueringer @k8s-infra-cherrypick-robot @johannesfrey