Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 surface failed preflight checks on MachineSet in MachinesCreated condition #8669

Merged
merged 1 commit into from
Jun 5, 2023
Merged

🌱 surface failed preflight checks on MachineSet in MachinesCreated condition #8669

merged 1 commit into from
Jun 5, 2023

Conversation

ykakarap
Copy link
Contributor

What this PR does / why we need it:

Adds support to surface failing pre-flight checks of a MachineSet on the MachinesCreated condition using the PreflightCheckFailed reason.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 16, 2023
@ykakarap
Copy link
Contributor Author

This PR is built on top of #8595.

/hold until #8595 is merged.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2023
@ykakarap ykakarap changed the title [DO_NOT_REVIEW][WIP] surface failed preflight checks on MachineSet in MachinesCreated condition 🌱 [DO_NOT_REVIEW][WIP] surface failed preflight checks on MachineSet in MachinesCreated condition May 16, 2023
@ykakarap ykakarap force-pushed the pr-ms-preflight-checks_condition branch 4 times, most recently from 1fdd045 to 3c6bde9 Compare May 20, 2023 08:22
@ykakarap ykakarap force-pushed the pr-ms-preflight-checks_condition branch from 3c6bde9 to ee60a55 Compare May 26, 2023 06:13
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 26, 2023
@ykakarap ykakarap changed the title 🌱 [DO_NOT_REVIEW][WIP] surface failed preflight checks on MachineSet in MachinesCreated condition 🌱 surface failed preflight checks on MachineSet in MachinesCreated condition May 26, 2023
@ykakarap
Copy link
Contributor Author

/hold until #8595 is merged.

@ykakarap ykakarap force-pushed the pr-ms-preflight-checks_condition branch from ee60a55 to d2d9682 Compare May 26, 2023 16:08
@ykakarap ykakarap force-pushed the pr-ms-preflight-checks_condition branch from d2d9682 to e1a1105 Compare May 31, 2023 23:41
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 31, 2023
@ykakarap ykakarap force-pushed the pr-ms-preflight-checks_condition branch from 8b4a0ea to 031cb49 Compare June 2, 2023 05:31
@sbueringer
Copy link
Member

Thanks!

/lgtm
/assign @fabriziopandini

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 304897e544128fba031497cefb5f692b8cb9cbcc

@ykakarap ykakarap mentioned this pull request Jun 3, 2023
Merged
@fabriziopandini
Copy link
Member

great work!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2023
@sbueringer
Copy link
Member

/hold cancel
the other PR has been merged

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 3433393 into kubernetes-sigs:main Jun 5, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Jun 5, 2023
@johannesfrey
Copy link
Contributor

/area machineset

@k8s-ci-robot k8s-ci-robot added the area/machineset Issues or PRs related to machinesets label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@sbueringer sbueringer sbueringer left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/machineset Issues or PRs related to machinesets cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@ykakarap @sbueringer @k8s-ci-robot @fabriziopandini @johannesfrey