-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 Fix Documentation for Ignition Bootstrap Feature Gate Environment Variable #8651
🐛 Fix Documentation for Ignition Bootstrap Feature Gate Environment Variable #8651
Conversation
|
Welcome @STASiAN! |
Hi @STASiAN. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch - thanks for fixing this!
/lgtm
/approve
LGTM label has been added. Git tree hash: 465a57d7f04427ed83aa685a31a8a8499c10704d
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
/cherry-pick release-1.4 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-1.3 |
@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@killianmuldoon: new pull request created: #8652 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@killianmuldoon: new pull request created: #8653 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/area documentation |
What this PR does / why we need it:
This PR addresses an inconsistency found between our documentation and the actual code for setting the Ignition bootstrap feature gate environment variable. The aim is to ensure users are provided with accurate instructions, thus eliminating possible confusion or issues.
In the current documentation, users are instructed to use
export BOOTSTRAP_FORMAT_IGNITION=true
for the AWS provider.However, in the actual code, the environment variable is
BootstrapFormatIgnition=${EXP_BOOTSTRAP_FORMAT_IGNITION:=false}
.This PR updates the documentation to reflect the correct usage.