Release 0.1.0 #861
Release 0.1.0 #861
Conversation
justinsb
commented
Mar 29, 2019
justinsb
commented
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
approved
| @@ -22,7 +22,7 @@ export KUBEBUILDER_CONTROLPLANE_START_TIMEOUT ?=60s | |||
| export KUBEBUILDER_CONTROLPLANE_STOP_TIMEOUT ?=60s | |||
|
|
|||
| # Image URL to use all building/pushing image targets | |||
| export CONTROLLER_IMG ?= gcr.io/k8s-cluster-api/cluster-api-controller:latest | |||
| export CONTROLLER_IMG ?= gcr.io/k8s-cluster-api/cluster-api-controller:0.1.0 | |||
| export EXAMPLE_PROVIDER_IMG ?= gcr.io/k8s-cluster-api/example-provider-controller:latest | |||
There was a problem hiding this comment.
Note that I am not changing the EXAMPLE_PROVIDER_IMG ... I figure that's for CI and we should not release it (?)
There was a problem hiding this comment.
I think that correct
/cc @figo
There was a problem hiding this comment.
CI will set the EXAMPLE_PROVIDER_IMG based on git hash at runtime. so the tag latest here does not matter, hence no need to change.
There was a problem hiding this comment.
Should we prepend the version with a v (note I'm not overly opinionated either way)?
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: justinsb, vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Starting to document the deltas from the pre-numbered release process in #862 |
