Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add METRO env variable to Equinix Metal quickstart #8596

Merged
merged 1 commit into from
May 4, 2023
Merged

📖 Add METRO env variable to Equinix Metal quickstart #8596

merged 1 commit into from
May 4, 2023

Conversation

codinja1188
Copy link
Contributor

@codinja1188 codinja1188 commented May 3, 2023 •
edited
Loading

What this PR does / why we need it:

This PR adds a couple lines to the quick start guide to take advantage of automated, interconnected bare metal across our global metros.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 3, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: vasubabu / name: Vasubabu (b974ea0)

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label May 3, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @Vasubabu!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 3, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Vasubabu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 3, 2023
@codinja1188 codinja1188 changed the title Fix: updated missing ENV variables 📖 updated missing ENV variables May 3, 2023
killianmuldoon
killianmuldoon reviewed May 3, 2023
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 3, 2023
@fabriziopandini
Copy link
Member

Please add some explanation in the PR summary and possibly make the PR title more self-explanatory (it will be used for generating release notes)

@codinja1188 codinja1188 requested a review from killianmuldoon May 3, 2023 15:52
@killianmuldoon
Copy link
Contributor

/retitle 📖 Add METRO env variable to Equinix Metal quickstart

@k8s-ci-robot k8s-ci-robot changed the title 📖 updated missing ENV variables 📖 Add METRO env variable to Equinix Metal quickstart May 3, 2023
@killianmuldoon
Copy link
Contributor

@fabriziopandini I think we don't really need anything in the PR summary - we merge a lot of PRs with either empty or outdated summaries and don't use them in the release notes.

Is this something you think should be changed going forward?

@killianmuldoon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2023
cprivitere

This comment was marked as outdated.

Sign in to view

@codinja1188
📖 updated missing METRO ENV variables. This can help to take advantag…
8a54d22 
…e of automated,

       interconnected bare metal across our global metros.
@cprivitere
Copy link
Member

/remove-lgtm
pending the removal of the facility variable

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@killianmuldoon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 3, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 929ffa9aaf67409e2aa47e2bc8f5981423199b37

@killianmuldoon
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 3, 2023
@cprivitere
Copy link
Member

/approve

@codinja1188
Copy link
Contributor Author

/approve

@codinja1188 codinja1188 closed this May 4, 2023
@codinja1188 codinja1188 reopened this May 4, 2023
@cprivitere
Copy link
Member

/approve

fabriziopandini
fabriziopandini reviewed May 4, 2023
View reviewed changes
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cprivitere, fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 4, 2023
@killianmuldoon
Copy link
Contributor

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit e641738 into kubernetes-sigs:main May 4, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone May 4, 2023
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 4, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@killianmuldoon: new pull request created: #8608

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codinja1188 codinja1188 mentioned this pull request May 28, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini fabriziopandini left review comments

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@richardcase richardcase Awaiting requested review from richardcase

@cprivitere cprivitere Awaiting requested review from cprivitere

@killianmuldoon killianmuldoon Awaiting requested review from killianmuldoon

Assignees

@fabriziopandini fabriziopandini

@cprivitere cprivitere

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
6 participants
@codinja1188 @k8s-ci-robot @fabriziopandini @killianmuldoon @cprivitere @k8s-infra-cherrypick-robot