-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.4] 📖 Update versions doc with k8s v1.27 notes #8539
[release-1.4] 📖 Update versions doc with k8s v1.27 notes #8539
Conversation
Signed-off by: Furkat Gofurov ([email protected]) (cherry picked from commit af03bdd)
6273516
to
570d60b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: 1906738d9887e5bcfad20968ed5d050a24fbf64c
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@furkatgofurov7 I think we can merge |
@sbueringer we do? I was holding this back thinking we need to have a release (1.4.x) first 🤔 If that is not the case, please unhold, thanks! |
Ah good point, you're right! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
@sbueringer is it good to go now? considering v1.4.2 is out |
Yes! /hold cancel |
Signed-off by: Furkat Gofurov ([email protected])
(cherry picked from commit af03bdd)
What this PR does / why we need it:
Manually cherry-picks ##8520 considering this comment from original PR and assumes support for v1.27 will start from v1.4.2. This will be on hold until 1.4.x release out with 1.27 support and will be left as is or updated accordingly
Part of: #8459
cc @kubernetes-sigs/cluster-api-release-team
/hold