Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.4] 📖 Update versions doc with k8s v1.27 notes #8539

Conversation

furkatgofurov7
Copy link
Member

@furkatgofurov7 furkatgofurov7 commented Apr 17, 2023

Signed-off by: Furkat Gofurov ([email protected])

(cherry picked from commit af03bdd)

What this PR does / why we need it:
Manually cherry-picks ##8520 considering this comment from original PR and assumes support for v1.27 will start from v1.4.2. This will be on hold until 1.4.x release out with 1.27 support and will be left as is or updated accordingly

Part of: #8459

cc @kubernetes-sigs/cluster-api-release-team

/hold

@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Apr 17, 2023
@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 17, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 17, 2023
Signed-off by: Furkat Gofurov ([email protected])

(cherry picked from commit af03bdd)
@furkatgofurov7 furkatgofurov7 force-pushed the update-version-docs-release-1-4/furkat branch from 6273516 to 570d60b Compare April 17, 2023 19:29
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1906738d9887e5bcfad20968ed5d050a24fbf64c

@sbueringer
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2023
@sbueringer
Copy link
Member

@furkatgofurov7 I think we can merge

@furkatgofurov7
Copy link
Member Author

furkatgofurov7 commented Apr 19, 2023

@furkatgofurov7 I think we can merge

@sbueringer we do? I was holding this back thinking we need to have a release (1.4.x) first 🤔 If that is not the case, please unhold, thanks!

@sbueringer
Copy link
Member

Ah good point, you're right!

Copy link
Contributor

@g-gaston g-gaston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@furkatgofurov7
Copy link
Member Author

@sbueringer is it good to go now? considering v1.4.2 is out

@sbueringer
Copy link
Member

Yes!

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 2, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5034068 into kubernetes-sigs:release-1.4 May 2, 2023
@furkatgofurov7 furkatgofurov7 deleted the update-version-docs-release-1-4/furkat branch May 3, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants