add rbac generation to manifests build step #841
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds RBAC generation to Makefile in the git book. When working through the provider implementation instructions in the git book, I ran into the same issues that were mentioned and fixed in PR #750. However, simply adding these annotations to the actuator files didn't resolve the issues. They required a regeneration of the RBAC manifests. This PR adds the RBAC generation to the Makefile so that it happens everytime
make manifests
is called. This seems to fix said issue.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes N/A
Special notes for your reviewer:
N/A
Release note: