Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 book: add missing apiversion deprecation to migration docs #8375

Merged
merged 1 commit into from
Mar 27, 2023

Conversation

oscr
Copy link
Contributor

@oscr oscr commented Mar 26, 2023

What this PR does / why we need it:

The apiversion deprecations should also be in the migration docs.

Should be cherry picked into 1.4 branch.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Partof #8038

cc @sbueringer @killianmuldoon @ykakarap

@k8s-ci-robot
Copy link
Contributor

@oscr: The label(s) area/book cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:

The apiversion deprecations should also be in the migration docs.

Should be cherry picked into 1.4 branch.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Partof #8038

cc @sbueringer @killianmuldoon @ykakarap

/area book

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 26, 2023
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cherry-pick release-1.4

@oscr oscr force-pushed the add-apiversion-dep branch from 7c36576 to 164b26a Compare March 27, 2023 11:22
Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 27, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1faf0ea881cdf774c0c180a6dddd112b1f5e80a3

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit 197e7f9 into kubernetes-sigs:main Mar 27, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Mar 27, 2023
@oscr oscr deleted the add-apiversion-dep branch March 27, 2023 11:50
@oscr
Copy link
Contributor Author

oscr commented Mar 27, 2023

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot

@oscr: new pull request created: #8382

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants