Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 clusterctl: Add labels to OWNERS file #8342

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

oscr
Copy link
Contributor

@oscr oscr commented Mar 22, 2023

What this PR does / why we need it:
Testing automatic area labels (discussed in #8263) on a limited area to try it out.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Partof #8263

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 22, 2023
@oscr
Copy link
Contributor Author

oscr commented Mar 22, 2023

Question: why is the ci bot adding random emojis?

Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f5aaba56a0174ab4efc62a66df4c63bdded024ea

@killianmuldoon
Copy link
Contributor

Question: why is the ci bot adding random emojis?

I think it does this for the Owners file - not sure why though

Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: killianmuldoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit e4e35b0 into kubernetes-sigs:main Mar 22, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Mar 22, 2023
@k8s-ci-robot
Copy link
Contributor

@oscr: The label(s) /label area/clusterctl cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

In response to this:

/label area/clusterctl

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joekr
Copy link
Member

joekr commented Mar 22, 2023

/area clusterctl

Just testing @oscr
This is great!

@k8s-ci-robot k8s-ci-robot added the area/clusterctl Issues or PRs related to clusterctl label Mar 22, 2023
@oscr oscr deleted the add-owners-label-clusterctl branch March 22, 2023 22:10
@oscr
Copy link
Contributor Author

oscr commented Mar 22, 2023

It worked! Created a pr and the area was auto assigned: #8344

@sbueringer
Copy link
Member

sbueringer commented Mar 23, 2023

Question: why is the ci bot adding random emojis?

I think it does this for the Owners file - not sure why though

It has a plugin for it, not sure why 😃

The heart plugin celebrates certain GitHub actions with the reaction emojis. Emojis are added to pull requests that make additions to OWNERS or OWNERS_ALIASES files and to comments left by specified "adorees".

@sbueringer
Copy link
Member

Related

/joke

@k8s-ci-robot
Copy link
Contributor

@sbueringer: What did one plate say to the other plate? Dinner is on me!

In response to this:

Related

/joke

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

/meow

@k8s-ci-robot
Copy link
Contributor

@sbueringer: cat image

In response to this:

/meow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@oscr
Copy link
Contributor Author

oscr commented Mar 23, 2023

/bark
/shrug

@k8s-ci-robot
Copy link
Contributor

@oscr: dog image

In response to this:

/bark
/shrug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯ label Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. ¯\_(ツ)_/¯ ¯\\\_(ツ)_/¯
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants