🐛 Fix flaky wait in CRS test

[killianmuldoon]

I've seen a bunch of flakiness in this test - both locally and in CI. I think the issue is waiting for the APIServer to create the service which sometimes doesn't happen quickly. I've updated the test to just create the service directly.

/area testing

[sbueringer]

one nit

[killianmuldoon]

/cherry-pick release-1.4

[k8s-infra-cherrypick-robot]

@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

/cherry-pick release-1.3

[k8s-infra-cherrypick-robot]

@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

/cherry-pick release-1.2

[k8s-infra-cherrypick-robot]

@killianmuldoon: once the present PR merges, I will cherry-pick it on top of release-1.2 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: a9c982809ee546694f178f9b663854b29df14860

[sbueringer]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-infra-cherrypick-robot]

@killianmuldoon: #8334 failed to apply on top of branch "release-1.2":

Applying: Fix flaky wait in CRS test
Using index info to reconstruct a base tree...
M	exp/addons/internal/controllers/clusterresourceset_controller_test.go
Falling back to patching base and 3-way merge...
Auto-merging exp/addons/internal/controllers/clusterresourceset_controller_test.go
CONFLICT (content): Merge conflict in exp/addons/internal/controllers/clusterresourceset_controller_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix flaky wait in CRS test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@killianmuldoon: new pull request created: #8340

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@killianmuldoon: #8334 failed to apply on top of branch "release-1.3":

Applying: Fix flaky wait in CRS test
Using index info to reconstruct a base tree...
M	exp/addons/internal/controllers/clusterresourceset_controller_test.go
Falling back to patching base and 3-way merge...
Auto-merging exp/addons/internal/controllers/clusterresourceset_controller_test.go
CONFLICT (content): Merge conflict in exp/addons/internal/controllers/clusterresourceset_controller_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Fix flaky wait in CRS test
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sbueringer]

@killianmuldoon I think v1.2 & v1.3 should be good as we just implemented this feature & test with v1.4?

[killianmuldoon]

Yeah - didn't check to see which branches the test was actually on