Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Validate variables in defaulting webhook #8332

Conversation

killianmuldoon
Copy link
Contributor

Move variable validation from the Cluster validation webhook to the Cluster defaulting webhook

This fixes a race condition caused by moving variable definitions from ClusterClass spec to status. That change means there is a chance that the defaulting and validating webhook are working off of different versions of the ClusterClass as each independently retrieves it from the cache.

Fixes #

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 22, 2023
@killianmuldoon killianmuldoon force-pushed the pr-validate-variables-in-default-webhook branch 2 times, most recently from 7250c0a to 246de8a Compare March 22, 2023 13:49
@killianmuldoon
Copy link
Contributor Author

/retest
/test pull-cluster-api-e2e-full-main

@killianmuldoon killianmuldoon force-pushed the pr-validate-variables-in-default-webhook branch from 246de8a to 43e229f Compare March 22, 2023 15:19
@sbueringer
Copy link
Member

sbueringer commented Mar 22, 2023

/lgtm
/approve

/test pull-cluster-api-e2e-full-main

/hold
for e2e test & in case you want additional reviews from other folks before merging

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 22, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 520c0ad4ec31694beea5eb1a6daf8f6a5c459c0c

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2023
@sbueringer
Copy link
Member

sbueringer commented Mar 22, 2023

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Sorry, typo with v1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@killianmuldoon
Copy link
Contributor Author

/retest

Copy link
Member

@fabriziopandini fabriziopandini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [fabriziopandini,sbueringer]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sbueringer
Copy link
Member

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 23, 2023
@k8s-ci-robot k8s-ci-robot merged commit e88eccb into kubernetes-sigs:main Mar 23, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Mar 23, 2023
@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #8345

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@johannesfrey
Copy link
Contributor

/area clusterclass

@k8s-ci-robot k8s-ci-robot added the area/clusterclass Issues or PRs related to clusterclass label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterclass Issues or PRs related to clusterclass cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants