-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Remove v1alpha2 adoption logic from KCP #8328
🌱 Remove v1alpha2 adoption logic from KCP #8328
Conversation
lgtm pending linter fix |
ee169bd
to
3ce5e63
Compare
/lgtm @killianmuldoon do we want to / have to cherry-pick this PR? I assume it's just a cleanup and not necessary to get the upcoming ownerRef e2e test green as it's just removing dead code. |
LGTM label has been added. Git tree hash: 7dbcc9dd9d0896486d9b0fedd7cd1c6c52635f68
|
No need to cherry-pick IMO. As you said this is a cleanup - nothing to do with any of our current ownerRef tests. |
Signed-off-by: killianmuldoon <[email protected]>
3ce5e63
to
22ad6f3
Compare
/lgtm |
LGTM label has been added. Git tree hash: 7c288458be2c008fcee90860a4adbcaa6aff6eb7
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice cleanup
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/area provider/control-plane-kubeadm |
Remove adoption logic for v1alpha2 from the KCP controller. There is currently no direct support for upgrades from v1alpha2 to v1beta1. This code is designed to support that use case so it should be removed.
Clusters which are reconciled by 0.3.X / 0.4.X controllers before updating to v1beta1 will already have this ownerReference removed.
Fixes https://github.com/kubernetes-sigs/cluster-api/pull/8256/files#r1141658906