Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 update book on in-place propagation #8319

Merged
merged 1 commit into from
Mar 24, 2023
Merged

📖 update book on in-place propagation #8319

merged 1 commit into from
Mar 24, 2023

Conversation

ykakarap
Copy link
Contributor

What this PR does / why we need it:

This PR documents the new node label sync and propagation behavior in the CAPI book.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Part of #7731

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 20, 2023
@ykakarap
Copy link
Contributor Author

/cc @sbueringer @fabriziopandini

@ykakarap ykakarap mentioned this pull request Mar 20, 2023
Closed
19 tasks
@fabriziopandini
Copy link
Member

Kudos for this PR, it is very detailed and touches all the relavant part of the book
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 152e37b22645e45027d1a0769b16039a4e907ed1

@ykakarap
Copy link
Contributor Author

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot
Copy link

@ykakarap: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

Very nice. I really like how concise the documentation is

@ykakarap ykakarap force-pushed the node-label-docs-update branch from 49a42a0 to 81e3224 Compare March 23, 2023 03:29
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2023
@ykakarap ykakarap force-pushed the node-label-docs-update branch from 81e3224 to 8405ec5 Compare March 24, 2023 02:54
@fabriziopandini
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 24, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: a2d4bdaacf7a3a90217c6dfd6541e12e94970066

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2023
@fabriziopandini
Copy link
Member

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot merged commit 9f45df1 into kubernetes-sigs:main Mar 24, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.5 milestone Mar 24, 2023
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 24, 2023
Merged
@k8s-infra-cherrypick-robot
Copy link

@fabriziopandini: new pull request created: #8369

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbueringer sbueringer sbueringer left review comments

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@richardcase richardcase Awaiting requested review from richardcase

Assignees

@fabriziopandini fabriziopandini

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.5
Development

Successfully merging this pull request may close these issues.
5 participants
@ykakarap @fabriziopandini @k8s-ci-robot @k8s-infra-cherrypick-robot @sbueringer