Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Add soft ownership from clusters to ClusterResourceSetBinding #8318

Conversation

fabriziopandini
Copy link
Member

@fabriziopandini fabriziopandini commented Mar 20, 2023

What this PR does / why we need it:
#7680 removed the owner reference from cluster to ClusterResourceSetBinding, replacing it with a spec.ClusterName field

However, we did not fix the fake objects used for validating clusterctl move accordingly, and thus even if unit tests for move were passing, we are seeking flakiness in CI because there is no more a deterministic order between Cluster and ClusterResourceSetBinding (see details in the attached issue).

This PR fixes this issue by introducing soft ownership from clusters to ClusterResourceSetBinding; It also fixes the softOwnership test that was not really up to date with what the function is currently doing.

Which issue(s) this PR fixes:
Fixes #8316

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 20, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 20, 2023
@fabriziopandini fabriziopandini force-pushed the add-soft-ownership-from-clusters-to-clusterresourcesetbinding branch from 13f1305 to 4847063 Compare March 20, 2023 15:51
@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-full-main

@fabriziopandini
Copy link
Member Author

/test pull-cluster-api-e2e-informing-main
this error seems unrelated

@fabriziopandini
Copy link
Member Author

first run passed, trying to see if it works consistently
/test pull-cluster-api-e2e-full-main

@sbueringer
Copy link
Member

/assign @ykakarap

@fabriziopandini
Copy link
Member Author

also second run passed, trying one more
/test pull-cluster-api-e2e-full-main

@fabriziopandini
Copy link
Member Author

3 over 3 success, last one
/test pull-cluster-api-e2e-full-main

Copy link
Contributor

@ykakarap ykakarap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 21, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e1804cf848676075c58163bf5157d921ef3f4e9d

@sbueringer
Copy link
Member

/lgtm
/approve

Thx for the quick fix!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 21, 2023
@sbueringer
Copy link
Member

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #8323

In response to this:

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@fabriziopandini fabriziopandini deleted the add-soft-ownership-from-clusters-to-clusterresourcesetbinding branch March 24, 2023 14:24
@johannesfrey
Copy link
Contributor

/area clusterctl

@k8s-ci-robot k8s-ci-robot added the area/clusterctl Issues or PRs related to clusterctl label Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/clusterctl Issues or PRs related to clusterctl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Self-hosted e2e test is flaky
6 participants