Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update handler name validation rules #8280

Conversation

killianmuldoon
Copy link
Contributor

Update validation of extensionConfig names and runtime SDK handler names to make parsing them from the format in the ClusterClass patch - i.e. handler.extension-config clearer.

Part of #7985

/area runtime-sdk

@k8s-ci-robot k8s-ci-robot added the area/runtime-sdk Issues or PRs related to Runtime SDK label Mar 14, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 14, 2023
@killianmuldoon killianmuldoon force-pushed the pr-runtimesdk-validate-hooknam branch from ddf354b to cc24e96 Compare March 14, 2023 10:58
@killianmuldoon killianmuldoon force-pushed the pr-runtimesdk-validate-hooknam branch from cc24e96 to a57e32b Compare March 14, 2023 11:11
@sbueringer
Copy link
Member

/lgtm
/approve

/cherry-pick release-1.4

@k8s-infra-cherrypick-robot

@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.4 in a new PR and assign it to you.

In response to this:

/lgtm
/approve

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 15b4bcb6e54ed2c442b85b422b8c1146925bfed9

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2023
@k8s-ci-robot k8s-ci-robot merged commit 88d47b2 into kubernetes-sigs:main Mar 14, 2023
@k8s-ci-robot k8s-ci-robot added this to the v1.4 milestone Mar 14, 2023
@k8s-infra-cherrypick-robot

@sbueringer: new pull request created: #8283

In response to this:

/lgtm
/approve

/cherry-pick release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/runtime-sdk Issues or PRs related to Runtime SDK cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants