-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 replace reflect deepequal in bootstrap kubeadm #8266
Conversation
Let's wait with merging this until we branched v1.4 away later today I would prefer not rushing this into this release so we can have it together with subsequent/corresponding changes in the next one |
Just realized that this PR is only touching test code. I think then it doesn't matter if this PR goes in before or after we cut the release branch |
/lgtm |
LGTM label has been added. Git tree hash: 10d4dba46071bb7508ca5d3e4130e9934e533e93
|
/lgtm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: killianmuldoon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/area provider/bootstrap-kubeadm |
What this PR does / why we need it:
replacing reflect.deepequal with cmp.Diff to which provides better diff for debugging purposes
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #8186
This PR is for bootstrap/kubeadm will be following up with more