-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 clusterctl: return early if release for latest tag does not exist yet #8253
🐛 clusterctl: return early if release for latest tag does not exist yet #8253
Conversation
d2c9974
to
48d467a
Compare
Taking back to VIP to go over unit tests and add new ones /retitle WIP 🐛 clusterctl: return early if release for latest tag does not exist yet |
48d467a
to
42e0607
Compare
/retitle 🐛 clusterctl: return early if release for latest tag does not exist yet |
42e0607
to
05bf57f
Compare
May needs adjustments after #8240 merges |
05bf57f
to
c34d48e
Compare
c34d48e
to
9a1b6a8
Compare
9a1b6a8
to
be16f6c
Compare
@fabriziopandini / @ykakarap , apologise for the ping :-) buy could you give it another look? |
Overall LGTM. Just one nit: #8253 (comment) |
lgtm pending the change to the error message suggested by @ykakarap |
be16f6c
to
e3f73a6
Compare
Fixed + squashed :-) |
/lgtm |
LGTM label has been added. Git tree hash: 84bd56f17a9e465b72222c09802e0545f5487033
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ykakarap The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.4 |
@killianmuldoon: new pull request created: #8965 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…r-api intermittently retrieving either non-existent provider releases or failing to retrieve legitimate provider releases. Related bug kubernetes-sigs/cluster-api#7889. This bug is linked to a partial fix kubernetes-sigs/cluster-api#8253 fixed in cluster-api v1.5.0. On uptaking cluster-api v1.5.0, we may no longer require to set the GOPROXY environment variable.
…r-api intermittently retrieving either non-existent provider releases or failing to retrieve legitimate provider releases. Related bug kubernetes-sigs/cluster-api#7889. This bug is linked to a partial fix kubernetes-sigs/cluster-api#8253 fixed in cluster-api v1.5.0. On uptaking cluster-api v1.5.0, we may no longer require to set the GOPROXY environment variable.
Updated capi ApplyUpgradeOptions when capi version overrides are specified Setting GOPROXY to direct to avoid Not Found 404 errors due to cluster-api intermittently retrieving either non-existent provider releases or failing to retrieve legitimate provider releases. Related bug kubernetes-sigs/cluster-api#7889. This bug is linked to a partial fix kubernetes-sigs/cluster-api#8253 fixed in cluster-api v1.5.0. On uptaking cluster-api v1.5.0, we may no longer require to set the GOPROXY environment variable.
Updated capi ApplyUpgradeOptions when capi version overrides are specified Setting GOPROXY to direct to avoid Not Found 404 errors due to cluster-api intermittently retrieving either non-existent provider releases or failing to retrieve legitimate provider releases. Related bug kubernetes-sigs/cluster-api#7889. This bug is linked to a partial fix kubernetes-sigs/cluster-api#8253 fixed in cluster-api v1.5.0. On uptaking cluster-api v1.5.0, we may no longer require to set the GOPROXY environment variable.
…#6909) Updated capi ApplyUpgradeOptions when capi version overrides are specified Setting GOPROXY to direct to avoid Not Found 404 errors due to cluster-api intermittently retrieving either non-existent provider releases or failing to retrieve legitimate provider releases. Related bug kubernetes-sigs/cluster-api#7889. This bug is linked to a partial fix kubernetes-sigs/cluster-api#8253 fixed in cluster-api v1.5.0. On uptaking cluster-api v1.5.0, we may no longer require to set the GOPROXY environment variable.
What this PR does / why we need it:
This PR adds the ability to detect a 404 error from the github client and handle the error differently than just bubbling up the usual error message.
It now also does not retry fetching the release on 404 errors and immediately returns instead.
Old output was (after 1m timeout):
New output is:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Partially fixing #7889